-
Notifications
You must be signed in to change notification settings - Fork 27.5k
feat($q): add shorthand for defining promise success or error handlers #3476
Conversation
@bolasblack - thanks for the PR. I notice that you have a commit that modifies the build on travis. Also the
|
@petebacondarwin i think you are right, so i removed the Thanks for your reminding. |
Great. Thanks |
@bolasblack bolasblack@f53f64a shouldn't be part of this PR, right? |
Cleaned up commit with updated docs here: |
@pkozlowski-opensource if this commit bolasblack/angular.js@f53f64a not exist, the PR will test failed. |
|
@IgorMinar it's ok now~ |
@IgorMinar I amended the commit :) |
@IgorMinar i don't know what happen, i don't kown why the test failed...
|
May be there is nothing wrong on your code. Travis behavior is being flaky for some time. You can retrigger Travis testing by amending the commit and pushing again to your repository with the By the way, it may be advisable to rebase the PR and take the |
Now we can instead this promise.then(null, errorHandler) with this promise.catch(errorhandler) Closes angular#2048
@lrlopez thanks for your help, i trid your method, but i'm afraid it did not work for me... |
Sorry to hear that... Seems that E2E tests via Travis are broken in current master. I've found another PR unrelated to yours with the same error. |
travis is totally borked right now.. looks like a node.js issue, but we can't reliably reproduce it outside of travis :-( I merged the $q commit after some minor modifications. thanks! |
@IgorMinar thanks for merging this. |
Now we can instead this
like this
Closes #2048